Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve the double port expose for Prometheus metrics #333

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

dimtas
Copy link
Contributor

@dimtas dimtas commented Oct 28, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MR2011 MR2011 merged commit d5943ea into main Oct 28, 2024
4 checks passed
@MR2011 MR2011 deleted the fix-double-port-prom-expose branch October 28, 2024 08:11
MR2011 added a commit that referenced this pull request Oct 29, 2024
* chore(refactor): update servicename to serviceccrn throughout repo

* chore(refactor): update component to use ccrn throughout repo

* chore(refactor): update supportgroup to use ccrn throughout repo

* chore(refactor): added ccrn field to component version

* chore(refactor): revert changes to component version with ccrn

This reverts commit 0b4b386.

* Update tests.yaml (#323)

* Update codeql.yaml (#325)

* chore: add sleeps to suppress potential racing conditions which make tests fail. (#327)

* chore: increase license location threshold (#329)

* fix: Resolve the double port expose for Prometheus metrics (#333)

* chore(doc):uploaded images for Prod. design doc. (#311)

Co-authored-by: David Rochow <[email protected]>

* chore: create setup job in codeql.yaml (#335)

* chore: remove generated code (#324)

* chore: remove generated code

* Automatic application of license header

* chore: remove bot license header

* Automatic application of license header

---------

Co-authored-by: License Bot <[email protected]>

* chore: update build_query in codeql.yaml (#336)

* chore(deps): bump github.com/brianvoe/gofakeit/v7 from 7.0.4 to 7.1.1 (#330)

Bumps [github.com/brianvoe/gofakeit/v7](https://github.com/brianvoe/gofakeit) from 7.0.4 to 7.1.1.
- [Release notes](https://github.com/brianvoe/gofakeit/releases)
- [Commits](brianvoe/gofakeit@v7.0.4...v7.1.1)

---
updated-dependencies:
- dependency-name: github.com/brianvoe/gofakeit/v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Reimsbach <[email protected]>

* fix(test): added additonal readiness checks for DB (#334)

Co-authored-by: Michael Reimsbach <[email protected]>

* merge

* chore(refactor): update supportgroup to use ccrn throughout repo

* chore(refactor): added ccrn field to component version

* chore(refactor): revert changes to component version with ccrn

This reverts commit 0b4b386.

* fix wrong function name

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Michael Reimsbach <[email protected]>
Co-authored-by: copyonwrite <[email protected]>
Co-authored-by: Dimitrios Tassopoulos <[email protected]>
Co-authored-by: Lola <[email protected]>
Co-authored-by: David Rochow <[email protected]>
Co-authored-by: License Bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dustindemmerle pushed a commit that referenced this pull request Nov 6, 2024
* chore(refactor): update servicename to serviceccrn throughout repo

* chore(refactor): update component to use ccrn throughout repo

* chore(refactor): update supportgroup to use ccrn throughout repo

* chore(refactor): added ccrn field to component version

* chore(refactor): revert changes to component version with ccrn

This reverts commit 0b4b386.

* Update tests.yaml (#323)

* Update codeql.yaml (#325)

* chore: add sleeps to suppress potential racing conditions which make tests fail. (#327)

* chore: increase license location threshold (#329)

* fix: Resolve the double port expose for Prometheus metrics (#333)

* chore(doc):uploaded images for Prod. design doc. (#311)

Co-authored-by: David Rochow <[email protected]>

* chore: create setup job in codeql.yaml (#335)

* chore: remove generated code (#324)

* chore: remove generated code

* Automatic application of license header

* chore: remove bot license header

* Automatic application of license header

---------

Co-authored-by: License Bot <[email protected]>

* chore: update build_query in codeql.yaml (#336)

* chore(deps): bump github.com/brianvoe/gofakeit/v7 from 7.0.4 to 7.1.1 (#330)

Bumps [github.com/brianvoe/gofakeit/v7](https://github.com/brianvoe/gofakeit) from 7.0.4 to 7.1.1.
- [Release notes](https://github.com/brianvoe/gofakeit/releases)
- [Commits](brianvoe/gofakeit@v7.0.4...v7.1.1)

---
updated-dependencies:
- dependency-name: github.com/brianvoe/gofakeit/v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Reimsbach <[email protected]>

* fix(test): added additonal readiness checks for DB (#334)

Co-authored-by: Michael Reimsbach <[email protected]>

* merge

* chore(refactor): update supportgroup to use ccrn throughout repo

* chore(refactor): added ccrn field to component version

* chore(refactor): revert changes to component version with ccrn

This reverts commit 0b4b386.

* fix wrong function name

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Michael Reimsbach <[email protected]>
Co-authored-by: copyonwrite <[email protected]>
Co-authored-by: Dimitrios Tassopoulos <[email protected]>
Co-authored-by: Lola <[email protected]>
Co-authored-by: David Rochow <[email protected]>
Co-authored-by: License Bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants